-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apparent double nesting of rubies impacting bouten spacing and baseline shifts (when rubyReserve is used) #188
Comments
It looks like the core issue is that imscJS assumed that a span to which |
Hi @palemieux, Thank you for looking into this! I just want to highlight that even if I apply tts:textEmphasis within a textEmphasis_rubyReserveTest_002.xml.zip
The only time I don't see a baseline shift is when I have some character/punctuation preceding the first tts:textEmphasis |
@jbaden As a WIP, I had not deployed this branch to http://sandflow.com/imsc1_1/index.html . I have done so now. |
Thank you, @palemieux. I have re-reviewed my test files and I'm no longer seeing any baseline shifts. Thanks again for your help. Much Appreciated, |
Hi @palemieux,
After further testing and review, I believe the rubyReserve issue you identified may also impact boutens (tts:textEmphasis).
"To polyfill tts:rubyReserve, applyRubyReserve() inserts a zero-width ruby annotation before the first HTML span in each line. This breaks if the first span is itself within a ruby annotation. Probably can be fixed."
In the following XML excerpts & corresponding images generated from IMSC11 Renderer, I've noticed that the baseline shifts when boutens are applied if they are exercised at the very beginning of a line (Example 2). In Example 3, I've added punctuation before the tts:textEmphasis span and the baseline is preserved (as expected with rubyReserve):
Example 1
2-line Horizontal Event without Boutens; with rubyReserve:
<p begin="100000000t" dur="20000000t" region="bottom-left-justified" ebutts:multiRowAlign="start">強調したい時に使<br/>強調したい時に使</p>
Example 2
2-line Horizontal Event with Boutens + rubyReserve (no preceding character/punctuation before span tts:textEmphasis)
<p begin="120000000t" dur="20000000t" region="bottom-left-justified" ebutts:multiRowAlign="start"><span style="bouten-filled-circle-outside">強調したい時に使<br/>強調したい時に使</span></p>
Example 3
2-line Horizontal Event with Boutens + rubyReserve (with a preceding character/punctuation before span tts:textEmphasis)
<p begin="140000000t" dur="20000000t" region="bottom-left-justified" ebutts:multiRowAlign="start">〝<span tts:textEmphasis="filled circle before">強</span><span tts:textEmphasis="filled circle before">調</span><span tts:textEmphasis="filled circle before">し</span><span tts:textEmphasis="filled circle before">た</span><span tts:textEmphasis="filled circle before">い</span><span tts:textEmphasis="filled circle before">時</span><span tts:textEmphasis="filled circle before">に</span><span tts:textEmphasis="filled circle before">使</span><br/><span> </span><span tts:textEmphasis="filled circle after">強</span><span tts:textEmphasis="filled circle after">調</span><span tts:textEmphasis="filled circle after">し</span><span tts:textEmphasis="filled circle after">た</span><span tts:textEmphasis="filled circle after">い</span><span tts:textEmphasis="filled circle after">時</span><span tts:textEmphasis="filled circle after">に</span><span tts:textEmphasis="filled circle after">使</span>〞</p>
Test file:
w3c/imsc-tests#94
The text was updated successfully, but these errors were encountered: