Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimega: not all errors are propagated to log files #1377

Open
djfritz opened this issue Oct 23, 2019 · 1 comment
Open

minimega: not all errors are propagated to log files #1377

djfritz opened this issue Oct 23, 2019 · 1 comment
Assignees
Milestone

Comments

@djfritz
Copy link
Contributor

djfritz commented Oct 23, 2019

Describe your environment

  1. minimega version
    2.6

Describe the bug
Some errors are not being propagated anywhere but stderr, even if stderr logging is disabled:

log stderr false
log file foo

# will log to foo
broken command

# will not log to foo (see #1376 as to why this is an error)
vm config net a
unable to determine valid QEMU hosts -- exec: "kvm": executable not found in $PATH

Expected behavior
The second error should log to the file, not to stderr.

@djfritz
Copy link
Contributor Author

djfritz commented Oct 24, 2019

I'm guessing minicli/output.go needs to have Responses' String() and Error() functions reworked a bit. We want to push errors to the logging subsystem and non-error responses along the normal path, but it's not currently possible to separate those for later consumption by the cli back in minimega (String() joins them currently it looks like).

@jcrussell thoughts on changes here?

@djfritz djfritz added this to the 2.7 milestone Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants