Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace JSONSchema #236

Open
JeremyRubin opened this issue Oct 29, 2022 · 2 comments
Open

Replace JSONSchema #236

JeremyRubin opened this issue Oct 29, 2022 · 2 comments
Labels
enhancement New feature or request needs scoping

Comments

@JeremyRubin
Copy link
Collaborator

we'd like to replace JSONSchema with something simpler and "application specific" that can go into rust-bitcoin (that means no deps not already in rust-bitcoin). There can be a function from our spec -> JsonSchema too, for compatibility. DHall is not an option because it has a bunch of deps.

@ProofOfKeags
Copy link
Collaborator

Is the issue having deps that are managed by Cargo? I ask because hypothetically if Dhall was the right model (not asserting it is here), it could be reimplemented within rust-bitcoin. If it isn't but we want something similarly sophisticated we could end up with a significant amount of hand-rolled code in rust-bitcoin that "has nothing to do with" rust-bitcoin.

@JeremyRubin
Copy link
Collaborator Author

you'd have to ask e.g. @apoelstra about what is acceptable in rust-bitcoin land / what design goals should be.

Vendoring deps might help, but Dhall has a lot of deps, including things like parser generators, which would need to be reviewed as well. https://crates.io/crates/dhall/0.12.0/dependencies

@ProofOfKeags ProofOfKeags added enhancement New feature or request needs scoping labels Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs scoping
Projects
None yet
Development

No branches or pull requests

2 participants