Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements regarding applying box constraints #54

Open
sapo17 opened this issue Feb 23, 2023 · 0 comments
Open

Improvements regarding applying box constraints #54

sapo17 opened this issue Feb 23, 2023 · 0 comments
Assignees
Labels
Feature (P2) Priority 2 feature request

Comments

@sapo17
Copy link
Owner

sapo17 commented Feb 23, 2023

Feedback from David and notes from the thesis

Might be worth having a look at how ADAM usually handles box constraints (or if that is commonly done anywhere) - here it sounds like you basically force the parameters onto the contraints by projection in between ADAM steps. (You can always say this is good enough for our purposes.)
Feb 21, 2023 4:16 PM

You: Unfortunately could not find anything about this in Mitsuba.
Morever, they also seemed to suggest doing it this way. For example: https://mitsuba.readthedocs.io/en/stable/src/inverse_rendering/gradient_based_opt.html#Optimization
Feb 22, 2023 9:02 PM

Ha ok, well if everyone does it ... ;-) ... and it seems to work just fine.
Although I currently don't recall any paper that analysed this in more detail (and this is probably not the right place to do that either). My feeling is that one should also project the gradient when projecting the value to the constraint set, but that really is a question for some other work.
Feb 23, 2023 9:40 AM

@sapo17 sapo17 added the Feature (P2) Priority 2 feature request label Feb 23, 2023
@sapo17 sapo17 self-assigned this Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature (P2) Priority 2 feature request
Projects
None yet
Development

No branches or pull requests

1 participant