Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrator should be selected according to the selected parameters #55

Open
sapo17 opened this issue Feb 23, 2023 · 0 comments
Open

Integrator should be selected according to the selected parameters #55

sapo17 opened this issue Feb 23, 2023 · 0 comments
Assignees
Labels
Feature (P2) Priority 2 feature request

Comments

@sapo17
Copy link
Owner

sapo17 commented Feb 23, 2023

Current state

Integrator is selected according to the loaded scene parameters in the scene.

CRQ

The integrator should be selected according to the selected scene parameters by the user. Consequently, one can avoid using discontinuity handling integrators if the selected parameters do not introduce discontinuities. Currently this is not the case.

See also:
david.hahn: Is this not a question of whether the user has actually selected such a parameter for optimization? Could this selection change after file loading?
Feb 21, 2023 4:02 PM
You: This is a good CRQ
Feb 21, 2023 8:06 PM • EditDelete
You: However, the main difficulty mitsuba does not seem to allow changing the integrator after loading it :-(
Feb 21, 2023 8:07 PM • EditDelete
david.hahn: hm ok, now I'm a bit confused - doesn't then every scene have some potential for discontinuity? anyway if we end up always using path-replay backprop, that's fine too
Feb 23, 2023 9:34 AM
You: >> doesn't then every scene have some potential for discontinuity?
True.
I kinda build a workaround:
First the scene is loaded temporarily to control what type of scene parameters it contains.
Depending on those parameters, an integrator gets suggested.
Eventually, the model really loads the scene and uses that suggested integrator.
Feb 23, 2023 9:50 AM • EditDelete
You: Unfortunately its quite messy, but currently that's how mitsuba work--it also caused headache for scene resolution. The scene is reloaded everytime when user loads images, since the scene resolution is modified according to the loaded images --> messy :-(

@sapo17 sapo17 added the Feature (P2) Priority 2 feature request label Feb 23, 2023
@sapo17 sapo17 self-assigned this Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature (P2) Priority 2 feature request
Projects
None yet
Development

No branches or pull requests

1 participant