Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about allocateUnifiedGPUPage() allocation strategy in device.go #115

Open
Taoger-Xu opened this issue Nov 12, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@Taoger-Xu
Copy link

Taoger-Xu commented Nov 12, 2024

To Reproduce
MGPUSim version of commit ID: 0a6e944

Hello,

I have a question regarding the allocateUnifiedGPUPage() method in the device.go file. This function appears to allocate a physical page on a GPU, using devSelected to keep track of the last selected device.

From the code, it looks like a round-robin allocation strategy might be intended. However, I noticed that the method does not break out of the loop upon finding a suitable ActualGPU device with available pages, which results in traversing the entire list of ActualGPUs.

image

Thank you for your time and any insights you can provide!

@Taoger-Xu Taoger-Xu added the bug Something isn't working label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant