Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JsonLogger should accept Throwables in #exception #16

Open
awwitecki opened this issue Jul 26, 2018 · 0 comments
Open

JsonLogger should accept Throwables in #exception #16

awwitecki opened this issue Jul 26, 2018 · 0 comments

Comments

@awwitecki
Copy link

awwitecki commented Jul 26, 2018 •
edited
Loading

Currently JsonLogger#exception method accepts well.. Exception objects. IMHO it should base on the highest possible level of abstraction, i.e. Throwables.

I provided the PR for that: #15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@awwitecki