Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated plugin blocks the market #60

Open
aklakina opened this issue Oct 13, 2023 · 0 comments
Open

Outdated plugin blocks the market #60

aklakina opened this issue Oct 13, 2023 · 0 comments

Comments

@aklakina
Copy link

aklakina commented Oct 13, 2023

Hi

The whole logic of this plugin is bad and outdated.

Cause

The newer versions of ansible-lint offer a json formatted output for integration with tools and that formatting contains the path of the analyzed files. This way you wouldn't need to iterate over the InputFiles set object.

Correct logic of analyzing the playbooks with ansible-lint

Using the command ansible-lint -f json <sources>/ instead of specified paths would eliminate the huge overhead and also because of -f json instead of -p the integration to new versions would be a whole lot easier.

Reason of this issue

  • I tried to rewrite it on my local repository but because of the deprecated version tests I could not get it to test or build.
  • This is the only sonarqube integration plugin for ansible and since this exists noone wants to write a correct, working one and they just don't care about the overhead.

File to be fixed:

sonar-ansible-api/src/main/java/com/github/sbaudoin/sonar/plugins/ansible/rules/AbstractAnsibleSensor.java
at:

  • 116-169
  • 255-273

I am willing to help you integrate with newer versions and with the correct logic if you can create an environment where the current build runs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant