Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support https in build ingresses #78

Open
mileo opened this issue Oct 14, 2022 · 8 comments
Open

Support https in build ingresses #78

mileo opened this issue Oct 14, 2022 · 8 comments
Labels
enhancement New feature or request

Comments

@mileo
Copy link

mileo commented Oct 14, 2022

Some features depends of the use of HTTPS, for example service workers.

image

@sbidoul
Copy link
Owner

sbidoul commented Oct 17, 2022

Interesting. Is that a issue new in 16?

If there is no workaround in the browser, then we'll need to find a way to deploy and maintain a wildcard certificate.

@sbidoul sbidoul added the enhancement New feature or request label Oct 17, 2022
@sbidoul sbidoul changed the title HTTPS Support https in build ingresses Oct 17, 2022
@sbidoul
Copy link
Owner

sbidoul commented Nov 9, 2022

Before, it seems nginx did use a default self signed certificate if used forced an https URL.
haproxy does not do that, it would seem.

See also OCA/hr-attendance#80 (comment)

@mileo
Copy link
Author

mileo commented Nov 10, 2022

Interesting. Is that a issue new in 16?

If there is no workaround in the browser, then we'll need to find a way to deploy and maintain a wildcard certificate.

It's a issue on OCA/pos#835

But could apply to other features too.

@mileo
Copy link
Author

mileo commented Nov 10, 2022

@sbidoul we use rancher+k8s+nginx some example:

mileo@0f0a10b

@sbidoul
Copy link
Owner

sbidoul commented Nov 10, 2022

Yeah, but I'm not sure that generating a new letsencrypt certificate for each commit we do in OCA is going to be ok with the letsencrypt usage policies.

@mileo
Copy link
Author

mileo commented Nov 10, 2022

Yeah, but I'm not sure that generating a new letsencrypt certificate for each commit we do in OCA is going to be ok with the letsencrypt usage policies.

May be some guys of our team can awnser this one: @kardeco @ananiasfilho

@ananiasfilho
Copy link

Let's encrypt have many limitations as certs per IP, certs per domains and others. The best and single way maybe will run with a wildcard ssl certificate.

@sbidoul
Copy link
Owner

sbidoul commented Nov 11, 2022

I agree using a wildcard ssl certificate is the best solution. It's a bit of a burden to set up and maintain, though.

So in the meantime I enabled a default self-signed certificate on the OCA runboat instance.

So you can manually change the build URL to https, and manually accept the default certificate.
Not perfect but probably good enough for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants