Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New classpath management system in launchers might break #21034

Closed
hamzaremmal opened this issue Jul 4, 2024 · 2 comments · Fixed by #21121
Closed

New classpath management system in launchers might break #21034

hamzaremmal opened this issue Jul 4, 2024 · 2 comments · Fixed by #21121
Assignees
Labels
area:command line Issues tied to how our launchers handle on the command line. area:doctool area:runner Issues tied to the scala runner command. compat:windows itype:bug prio:high regression This worked in a previous version but doesn't anymore

Comments

@hamzaremmal
Copy link
Member

hamzaremmal commented Jul 4, 2024

Compiler version

main (f2829c3)

Issue example

#20631 changes the management of the classpath for the scaladoc.bat and scalac.bat commands. With this new structure, the length of the classpath is now much bigger than what is was previously and even reaching some of the limits set by windows : https://learn.microsoft.com/en-us/troubleshoot/windows-client/shell-experience/command-line-string-limitation

Discovered while debugging a workflow run in #20547

Expectation

We should reduce the length of the classpath variable to have enough margin to append other options and to avoid malfunctions

@bishabosha
Copy link
Member

the technique is ultimately the same as before, just the number of entries grew in scaladocs classpath

@hamzaremmal
Copy link
Member Author

Yes, this issue tackles the fact that now we have /maven2/.../file.jar instead of /lib/file.jar, therefore increasing the number of characters and reaching the limit set by Windows

@Gedochao Gedochao added the regression This worked in a previous version but doesn't anymore label Jul 5, 2024
@Gedochao Gedochao added area:doctool area:command line Issues tied to how our launchers handle on the command line. labels Jul 5, 2024
@hamzaremmal hamzaremmal linked a pull request Jul 8, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:command line Issues tied to how our launchers handle on the command line. area:doctool area:runner Issues tied to the scala runner command. compat:windows itype:bug prio:high regression This worked in a previous version but doesn't anymore
Projects
None yet
3 participants