Only allow erased parameters in erased definitions #19686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I don't think the issues regarding the lifting/evaluation of arguments to erased parameters are specific to the case of erased definitions.
We have the same problem here for example:
def bar(erased x: Int) = true
bar:
println("hello")
1which after pruneErasedDefs gives:
def bar(erased x: Int): Boolean = true
Test.bar(scala.compiletime.erasedValue[(1 : Int)])
Not completely. We still need to check the purity of the erased parameter before we prune it. This is just a first step. |
nicolasstucki
force-pushed
the
desallow-non-erased-params-in-erased-defs
branch
from
39eba3a
to
61b8336
Compare
nicolasstucki
force-pushed
the
desallow-non-erased-params-in-erased-defs
branch
from
61b8336
to
d335e93
Compare
So far, we do not have any use case for them. We could enable them in a later version. The current implementation does not handle correctly the non-erased arguments to erased definitions. These should always be evaluated, but in some cases we can dorp them by mistake.
nicolasstucki
force-pushed
the
desallow-non-erased-params-in-erased-defs
branch
from
d335e93
to
f4ff6e3
Compare
EugeneFlesselle
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, we do not have any use case for them. We could enable them in a later version.
The current implementation does not handle correctly the non-erased arguments to erased definitions. These should always be evaluated, but in some cases we can dorp them by mistake.