Rewrite reaches tests to fix tasty-cc nightly failures #20156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reaches.scala pos test failed the nightly with tasty cc since one line violated the new condition for reaches capabilities. The problem was not discoveed in normal testing since it used the `List` class, which is capture checked only in the nightly. We now make the relevant bits of `List` explicit in the test itself, so that it is always capture checked. The failing line got moved to neg.
Linyxus
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reaches.scala pos test failed the nightly with tasty cc since one line violated the new condition for reaches capabilities. The problem was not discoveed in normal testing since it used the
Listclass, which is capture checked only in the nightly. We now make the relevant bits ofListexplicit in the test itself, so that it is always capture checked. The failing line got moved to neg.[test_scala2_library_tasty]