-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Widen unsafe reach capabilities instead of erroring #20250
base: main
Are you sure you want to change the base?
Conversation
reaches.scala still has errors? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we rearrange this PR into two commits:
- One commit should contain all changes that we would want to revert when we change to existentials.
- The other commit should contain tests and everything else that we want to keep.
Rebasing is done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test failures still need fixing. Otherwise good to go in.
Mark the TypeMap as idempotent Tweak test case Fix checkfile for reaches.scala
Fixes #20204