Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize when verifying if TypeTestCasts are unchecked #20258

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

EugeneFlesselle
Copy link
Contributor

Not normalizing would also be fine with me,
but in that case pos/i13433b should become a neg test.

EugeneFlesselle added a commit to dotty-staging/dotty that referenced this pull request Apr 24, 2024
Related to scala#20258
Here too, I would be fine with not normalizing,
but in that case pos/i15827 should become a neg test.
@EugeneFlesselle EugeneFlesselle marked this pull request as ready for review April 24, 2024 19:34
Copy link
Member

@sjrd sjrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. This operation is definitely fundamentally subtyping-based, so the subtyping rules for reducing match types should carry here.

@EugeneFlesselle EugeneFlesselle merged commit 728d2e6 into scala:main Apr 25, 2024
17 of 18 checks passed
@EugeneFlesselle EugeneFlesselle deleted the match-types-TypeTests branch April 25, 2024 09:10
@Kordyjan Kordyjan added this to the 3.5.0 milestone May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants