Add regression test for issue 18726 #20318
Conversation
rochala
force-pushed
the
i18726-regression-test
branch
2 times, most recently
from
76a68cb
to
5bb98db
Compare
rochala
force-pushed
the
i18726-regression-test
branch
from
5bb98db
to
f5dc97f
Compare
| check( | ||
| """ | ||
| |object A { | ||
| | "".repea@@ |
There was a problem hiding this comment.
How is this actually working? I think I actually had to turn it off and -release options is removed:
There was a problem hiding this comment.
Sorry, but I don't understand the question. Are you asking about how the test is implemented or how are we handling the release flag ?
There was a problem hiding this comment.
How are the tests working? And maybe we need to stop removing the flag?
There was a problem hiding this comment.
Oh, I guess it is because I passed it as -release:8 and it is a single argument on the list, thus it is not removed ? We should remove this line tho beacuse -release 8 is a valid scala flag.
There was a problem hiding this comment.
Do you remember why we added this check in the first place ?
There was a problem hiding this comment.
It might have been interfering with some other options and it seemed not important for frontend phases scalameta/metals#3812
There was a problem hiding this comment.
I just tested it and seems to work ok with that removed.
Co-authored-by: Tomasz Godzik <[email protected]>
Closes #18726
[test_windows_full]