Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring back ambiguity filter when we report an implicit not found error #20368

Merged
merged 2 commits into from
May 8, 2024
Merged

Bring back ambiguity filter when we report an implicit not found error #20368

merged 2 commits into from
May 8, 2024

Conversation

odersky
Copy link
Contributor

@odersky odersky commented May 8, 2024

This reverts one part of #20261. When we fail with both an ambiguity on one implicit argument and another error on another argument we prefer the other error. I added a comment why this is needed.

Fixes #20344

@odersky
Bring back ambiguity filter when we report an implicit not found error
863077c 
This reverts one part of scala#20261. When we fail with both an ambiguity on one implicit argument and another error on another argument we prefer the other error. I added a comment why this is needed.

Fixes scala#20344
@odersky odersky added this to the 3.5.0-RC2 milestone May 8, 2024
@odersky
Copy link
Contributor Author

odersky commented May 8, 2024

I added to a 3.5.0-RC2 milestone since this fixes a regression

@odersky odersky mentioned this pull request May 8, 2024
Closed
@mbovel mbovel self-requested a review May 8, 2024 17:56
mbovel
mbovel approved these changes May 8, 2024
View reviewed changes
compiler/src/dotty/tools/dotc/typer/Typer.scala Outdated Show resolved Hide resolved
@odersky odersky merged commit b10d64e into scala:main May 8, 2024
19 checks passed
@odersky odersky deleted the fix-20344 branch May 8, 2024 22:47
@smarter smarter added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label May 14, 2024
@WojciechMazur WojciechMazur mentioned this pull request Jun 17, 2024
Merged
@WojciechMazur WojciechMazur added backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" backport:done This PR was successfully backported. and removed backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" labels Jun 17, 2024
@WojciechMazur WojciechMazur mentioned this pull request Jul 6, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jul 6, 2024
@WojciechMazur
Backport "Bring back ambiguity filter when we report an implicit not …
6ff12a3 
…found error" to LTS (#21103)

Backports #20368 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbovel mbovel mbovel approved these changes

Assignees
No one assigned
Labels
backport:done This PR was successfully backported.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression in armanbilge/schrodinger for implicit search
4 participants
@odersky @mbovel @smarter @WojciechMazur