From 0ee87625e80566ae52e236030b4af70f039c40fb Mon Sep 17 00:00:00 2001
From: Guillaume Martres <smarter@ubuntu.com>
Date: Tue, 28 May 2024 19:07:05 +0200
Subject: [PATCH] Expr#show: Don't crash when the expression contains an
 unsupported type (like a SkolemType)

When the SkolemType appears as the prefix of a TypeRef, we avoid it by going
using `qualifier` which is defined in QuotesImpl to widen skolem, but skolems
can appear in any position, and so before this change we would get a compiler
crash in the added test case where the skolem appears as the prefix of a
TermRef.

We fix this by adding fallback cases in the quotes pretty-printer, now for the
test case we get:

    Test.f.ho(((arg: <<SkolemType(693709097) does not have a corresponding extractor> does not have a source representation>.x.type) => arg))

Which isn't great, but better than a crash.

Maybe we should run `Type#deskolemized` on a type before trying to print it in
SourceCode/Extractors, but currently these files are intentionally defined to
not depend on compiler internals and do not have a `Context` so we cannot even
call `deskolemized` on them.

Alternatively, maybe SkolemType should be a tasty-reflect constructor but that
would also be a pretty big change.
---
 .../quoted/runtime/impl/printers/Extractors.scala      |  4 ++++
 .../quoted/runtime/impl/printers/SourceCode.scala      |  8 +++++---
 tests/pos-macros/skolem/Macro_1.scala                  | 10 ++++++++++
 tests/pos-macros/skolem/Test_2.scala                   |  9 +++++++++
 tests/run-macros/i19905.check                          |  4 ++--
 5 files changed, 30 insertions(+), 5 deletions(-)
 create mode 100644 tests/pos-macros/skolem/Macro_1.scala
 create mode 100644 tests/pos-macros/skolem/Test_2.scala

diff --git a/compiler/src/scala/quoted/runtime/impl/printers/Extractors.scala b/compiler/src/scala/quoted/runtime/impl/printers/Extractors.scala
index acf66fcf2009..82be54a9d793 100644
--- a/compiler/src/scala/quoted/runtime/impl/printers/Extractors.scala
+++ b/compiler/src/scala/quoted/runtime/impl/printers/Extractors.scala
@@ -177,6 +177,8 @@ object Extractors {
         this += "Alternatives(" ++= patterns += ")"
       case TypedOrTest(tree, tpt) =>
         this += "TypedOrTest(" += tree += ", " += tpt += ")"
+      case tree =>
+        this += s"<Internal compiler AST $tree does not have a corresponding reflect extractor>"
     }
 
     def visitConstant(x: Constant): this.type = x match {
@@ -241,6 +243,8 @@ object Extractors {
         this += "MatchCase(" += pat += ", " += rhs += ")"
       case FlexibleType(tp) =>
         this += "FlexibleType(" += tp += ")"
+      case tp =>
+        this += s"<Internal compiler type $tp does not have a corresponding reflect extractor>"
     }
 
     def visitSignature(sig: Signature): this.type = {
diff --git a/compiler/src/scala/quoted/runtime/impl/printers/SourceCode.scala b/compiler/src/scala/quoted/runtime/impl/printers/SourceCode.scala
index 9503177ff738..a1f54c5a2069 100644
--- a/compiler/src/scala/quoted/runtime/impl/printers/SourceCode.scala
+++ b/compiler/src/scala/quoted/runtime/impl/printers/SourceCode.scala
@@ -1292,7 +1292,9 @@ object SourceCode {
           val sym = annot.tpe.typeSymbol
           sym != Symbol.requiredClass("scala.forceInline") &&
           sym.maybeOwner != Symbol.requiredPackage("scala.annotation.internal")
-        case x => cannotBeShownAsSource(x.show(using Printer.TreeStructure))
+        case x =>
+          cannotBeShownAsSource(x.show(using Printer.TreeStructure))
+          false
       }
       printAnnotations(annots)
       if (annots.nonEmpty) this += " "
@@ -1463,8 +1465,8 @@ object SourceCode {
       }
     }
 
-    private def cannotBeShownAsSource(x: String): Nothing =
-      throw new Exception(s"$x does not have a source representation")
+    private def cannotBeShownAsSource(x: String): this.type =
+      this += s"<$x does not have a source representation>"
 
     private object SpecialOp {
       def unapply(arg: Tree): Option[(String, List[Term])] = arg match {
diff --git a/tests/pos-macros/skolem/Macro_1.scala b/tests/pos-macros/skolem/Macro_1.scala
new file mode 100644
index 000000000000..65b14cffbc5b
--- /dev/null
+++ b/tests/pos-macros/skolem/Macro_1.scala
@@ -0,0 +1,10 @@
+import scala.quoted.*
+
+object Macro {
+
+  def impl(expr: Expr[Any])(using Quotes): Expr[Unit] =
+    println(expr.show)
+    '{ () }
+
+  inline def macr(inline x: Any): Unit = ${impl('x)}
+}
diff --git a/tests/pos-macros/skolem/Test_2.scala b/tests/pos-macros/skolem/Test_2.scala
new file mode 100644
index 000000000000..e243b8844c23
--- /dev/null
+++ b/tests/pos-macros/skolem/Test_2.scala
@@ -0,0 +1,9 @@
+trait Foo:
+  val x: Int
+  def ho(p: x.type => x.type): Unit = ()
+
+object Test {
+  var f: Foo = ???
+  Macro.macr:
+    f.ho(arg => arg)
+}
diff --git a/tests/run-macros/i19905.check b/tests/run-macros/i19905.check
index 36ba7772bfdb..47e9d86e3662 100644
--- a/tests/run-macros/i19905.check
+++ b/tests/run-macros/i19905.check
@@ -1,3 +1,3 @@
-java.lang.Exception: NoPrefix() does not have a source representation
-java.lang.Exception: NoPrefix() does not have a source representation
+<NoPrefix() does not have a source representation>
+<NoPrefix() does not have a source representation>
 NoPrefix()