Global Initialization checker: Widen values in assignment #21512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olhotak
requested changes
Aug 30, 2024
| * User-specified widening annotations are repected. | ||
| */ | ||
| def widenEscapedValue(value: Value, expr: Tree): Contextual[Value] = | ||
| expr.tpe.getAnnotation(defn.InitWidenAnnot) match |
There was a problem hiding this comment.
This implements the default as 1 or 2 if there is no annotation, but the default when there is a malformed annotation is always 1.
It would be cleaner to first compute the default widening level (1 or 2), and then do the parsing of the annotation, using that default widening level if annotation parsing fails.
Even cleaner would be a function like:
def parseAnnotation: Option[Int]that returns None if there is no annotation or there is an annotation that cannot be parsed. Then
parseAnnotation match
case Some(i) => value.widen(i)
case None => if ... then value.widen(2) else value.widen(1)| * The default widening is 1 for most values, 2 for function values. | ||
| * User-specified widening annotations are repected. | ||
| */ | ||
| def widenEscapedValue(value: Value, expr: Tree): Contextual[Value] = |
There was a problem hiding this comment.
I'd suggest renaming expr to something more specific such as annotatedTree or annotationHost.
olhotak
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Global Initialization checker: Widen values in assignment