Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed false positive unreachable local object #21532

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Fixed false positive unreachable local object #21532

merged 1 commit into from
Sep 5, 2024
+10 −0

Conversation

dwijnand
Copy link
Member

@dwijnand dwijnand commented Sep 3, 2024

I think this was fixed in PR 21000, but I didn't check.

Closes #21218

@dwijnand
Fixed false positive unreachable local object
54ae45d 
I think this was fixed in PR 21000, but I didn't check.
@WojciechMazur
Copy link
Contributor

WojciechMazur commented Sep 5, 2024 •
edited
Loading

Bisect points to 5b425ee as a commit that fixed the issue. It's strange as this single commit has not introduced any changes, but running bisect script with --should-fail could have messed something up. Anyway it points to #21000

@dwijnand dwijnand marked this pull request as ready for review September 5, 2024 17:11
@dwijnand dwijnand merged commit 5a7627a into scala:main Sep 5, 2024
28 checks passed
@dwijnand dwijnand deleted the fixed-space-local-object branch September 5, 2024 17:11
@WojciechMazur WojciechMazur mentioned this pull request Sep 5, 2024
Merged
WojciechMazur added a commit that referenced this pull request Sep 6, 2024
@WojciechMazur
Backport "Fix a bundle of patmat issues" to 3.3.4 (#21549)
1a5bff6 
Backports #21000 and #21532 to 3.3.4-RC2. Fixes regression introduced in
RC1
@dwijnand dwijnand mentioned this pull request Sep 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WojciechMazur WojciechMazur WojciechMazur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False-positive unreachable warning for a match using local object
2 participants
@dwijnand @WojciechMazur