Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow imports nested in packagings to shadow #21539

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Allow imports nested in packagings to shadow #21539

wants to merge 2 commits into from

Conversation

dwijnand
Copy link
Member

@dwijnand dwijnand commented Sep 4, 2024 •
edited
Loading

Fixes #21405

@dwijnand
Allow imports nested in packagings to shadow
af0283f
@dwijnand
Fix CompletionTest.importAnnotationAfterImport expectations
905cbd1 
So, before my change, importing java.lang.annotation and then importing
"annotation" will return java.lang.annotation, but complete as
scala.annotation - so the completion logic (in scopeCompletions) is
wrong somewhere.  After my change they both return java.lang.annotation,
so looks like I might have unintentionally made that logic work for this
case - just need to update the test expectation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Import outside a package clause is not shadowed by an import inside the package clause
1 participant
@dwijnand