Remove the -rewrite option for typechecks methods in Quotes
#21547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamzaremmal
reviewed
Sep 10, 2024
| @@ -342,10 +342,13 @@ object Inlines: | |||
| if Inlines.isInlineable(codeArg1.symbol) then stripTyped(Inlines.inlineCall(codeArg1)) | |||
| else codeArg1 | |||
|
|
|||
| // We should not be rewriting tested strings | |||
| val noRewriteSettings = ctx.base.settings.rewrite.update(None) | |||
There was a problem hiding this comment.
Actually, this call might either mutate the state in the ctx itself and return that context's SettingState or it will return a new SettingState depending on the state of reading the setting itself. See:
scala3/compiler/src/dotty/tools/dotc/config/Settings.scala
Lines 44 to 49 in 7d12783
There was a problem hiding this comment.
Ah, I did not realize this was the case. Thank you for the catch!
jchyb
force-pushed
the
i21415-type-check-errors
branch
from
990ebf3
to
3025bfb
Compare
jchyb
force-pushed
the
i21415-type-check-errors
branch
from
3025bfb
to
6f21759
Compare
hamzaremmal
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21415
This is somewhat related to #21185, but I think it's better to merge this one separately first since it's an easy backport, which might not be the case with the other PR (since we are technically changing the semantics there)