Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check whether MAXIMUM_ACTION_COUNT_PER_SAVE should depend again on tracing type #8274

Open
philippotto opened this issue Dec 12, 2024 · 0 comments

Comments

@philippotto
Copy link
Member

With #7839, the logic for selecting how many actions can be put into one save request got a bit simpler. Previously, the amount of actions was thresholded against constants that depended on the tracing type. E.g., 15000 skeleton actions, but only 3000 volume actions could be put into one save request. This logic got lost, but could get re-introduced. The benefit would be more efficient saves. However, it's not clear whether this is really important.

My suggestion: we should keep an eye on how fast saving performs. Alternatively, we could benchmark it explicitly, but the priority seems rather low. Still, I want to record this topic in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant