Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard: hide not-yet-fully-uploaded datasets if »show only available« is selected #8276

Open
fm3 opened this issue Dec 12, 2024 · 2 comments

Comments

@fm3
Copy link
Member

fm3 commented Dec 12, 2024

I’d say these datasets should not be visible in this filter case. Do you agree @philippotto ?

If so, we can have a look if the code needs to be changed in frontend or backend (I’m not currently sure how this filtering is implemented)

@philippotto
Copy link
Member

I think, it's filtered by the back-end (via the GET parameter isFinished whose name is a bit confusing in this case).

I’d say these datasets should not be visible in this filter case. Do you agree @philippotto ?

Yes, sounds fair.

@fm3 fm3 changed the title Should the dashboard show now-yet-fully-uploaded datasets even if »show only available« is selected? Dashboard: hide now-yet-fully-uploaded datasets if »show only available« is selected Dec 12, 2024
@fm3 fm3 changed the title Dashboard: hide now-yet-fully-uploaded datasets if »show only available« is selected Dashboard: hide not-yet-fully-uploaded datasets if »show only available« is selected Dec 18, 2024
@fm3
Copy link
Member Author

fm3 commented Dec 18, 2024

The property used for this filtering is called isUnreported. Currently, unreported is defined as one of "No longer available on datastore.", "Deleted by user.".

There is also the property isActive. so isActive==false would also include "Not yet fully uploaded.". Maybe we should just switch the filtering to use isActive instead of isUnreported?

But this makes the isUnreported property completely unused. So I’m now thinking maybe this was actually all intentional… 🤔

@fm3 fm3 removed the bug label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants