installJsdom may installs jsdom outside of the target directory

[unarist]

installJsdom seems to install jsdom into target.value / "scalajs-bundler-jsdom".

scalajs-bundler/sbt-scalajs-bundler/src/main/scala/scalajsbundler/sbtplugin/ScalaJSBundlerPlugin.scala

Lines 606 to 608 in 716c921

	installJsdom := {
	val installDir = target.value / "scalajs-bundler-jsdom"
	val baseDir = baseDirectory.value

However, it may install into other directory if:

• default install directory target.value / "scalajs-bundler-jsdom" does not exists, and
• any its ancestor directory has one of:
  • node_modules directory (even if it's empty)
  • package.json file

This behavior unexpectedly edits other file which is not related to Scala project. Also, simultaneous installJsdom execution from sbt projects sometimes fails due to writing same node_modules directory.

For a workaround, I'm thinking about overriding installJsdom task.

Reproducing steps

1. Prepare sbt project with following files
2. Run npm init -y to create empty package.json
3. Run sbt test
4. ... then I expected there is no node_modules directory in the root directory, but it exists

/project/plugins.sbt

addSbtPlugin("org.scala-js" % "sbt-scalajs" % "1.3.0")
addSbtPlugin("ch.epfl.scala" % "sbt-scalajs-bundler" % "0.20.0")

/build.sbt

scalaVersion := "2.12.11"
enablePlugins(ScalaJSBundlerPlugin)
Test / requireJsDomEnv := true