Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance corporate pom structure #6

Closed
dmytro-lazebnyi opened this issue Jul 30, 2018 · 4 comments
Closed

Enhance corporate pom structure #6

dmytro-lazebnyi opened this issue Jul 30, 2018 · 4 comments
Assignees
Labels
wontfix This will not be worked on

Comments

@dmytro-lazebnyi
Copy link
Member

Motivation

Corporate POM have to declare all third-party plugins and dependepcies.
All project have to use same versions of any third-party library to avoid difference of dependencies.

Needs to be done

  • Plugins have to be described in pluginManagement section and simply used in plugins section
  • Dependencies have to be described dependencyManagement sections
  • Versions of dependencies have to be declared in properties section as it is done for plugins
@dmytro-lazebnyi dmytro-lazebnyi added the enhancement New feature or request label Jul 30, 2018
@aharonha
Copy link
Contributor

@dmytro-lazebnyi As I see it, dependencies are to be set in a bom rather then pom
So, for example we would have a pom package for depending on multiple artifacts, then on the parent pom (not the super) we can add a dependency with scope import to this bom that would import all of our dependencies.
@scalecube/developers What do you think?

@aharonha aharonha self-assigned this Jul 31, 2018
@aharonha
Copy link
Contributor

aharonha commented Jul 31, 2018

Lets agree on some guidelines:

  1. we should have all of our ++ only ++ the most common third party dependencies in the super pom
  2. test scope should also be set.
  3. sibling projects (modules in the same git repository) are not to be managed
  4. let's have a discussion about scalecube projects which are not in the same repository
  5. let's discuss Use versions-maven-plugin/update-parent scalecube-travis-ci#17

@ronenhamias
Copy link
Member

  1. we should have all of our ++ only ++ the most common third party dependencies in the super pom

having a lib version in this project makes it really hard to update and test.
i really suggest to keep only administrative stuff here that are rock solid relate to build and release and general project standards.

@dmytro-lazebnyi
Copy link
Member Author

@ronenhamias
Yep, looks like it was a not good idea to have any common dependencies in corporate pom.
I've just created pull request #55 to remove even test dependencies.

@dmytro-lazebnyi dmytro-lazebnyi added wontfix This will not be worked on and removed enhancement New feature or request labels Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants