Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloudimage-360-left and cloudimage-360-right elments are never created #139

Open
dotnetwise opened this issue Dec 20, 2022 · 10 comments
Open
Labels
help wanted Extra attention is needed

Comments

@dotnetwise
Copy link

And the same for the top and bottom
I think you had them before and removed that code

Adding data-keys doesn't display them

@amrw-js amrw-js added the help wanted Extra attention is needed label Dec 21, 2022
@amrw-js
Copy link
Collaborator

amrw-js commented Dec 21, 2022

hi @dotnetwise ,
if you need to display the control elements you have to use
data-controls

@amrw-js amrw-js closed this as completed Dec 21, 2022
@dotnetwise
Copy link
Author

dotnetwise commented Dec 21, 2022 via email

@amrw-js
Copy link
Collaborator

amrw-js commented Apr 10, 2023

hey @dotnetwise, can you please show me the bug in a codesandbox?

@amrw-js amrw-js reopened this Apr 10, 2023
@DATEx2
Copy link

DATEx2 commented Apr 10, 2023

unfortunately we no longer use your product as it was not mobile friendly (touch, pan & zoom, double tap etc.) - we use a better one (suited for our mobile experience needs instead), so I can no longer help with the repo, but I believe you can try on your page with your phone and see if it always renders correctly. It was randomly doing nothing and randomly working (race events due to different loading events, I suppose)

@amrw-js
Copy link
Collaborator

amrw-js commented Apr 28, 2023

hey @DATEx2, the touch events have been fixed in v3.1.0. while panning, and zoom is a feature we already added to our roadmap.

@joshsedl
Copy link

data-controls? On your demo page, it says data-control:
image

And the feature is also not documented:
https://github.com/scaleflex/js-cloudimage-360-view?tab=readme-ov-file#-config

@joshsedl
Copy link

But this is definitly a bug, simply adding data-control won't show any controls. They have to be added manually, see https://codesandbox.io/s/js-cloudimage-360-view-example-forked-m57v8c?file=/index.html.

@joshsedl
Copy link

Unfortunately, I don't have the permissions to change the label of this issue nor the issue title.

@DATEx2
Copy link

DATEx2 commented Sep 19, 2024

Unfortunately, I don't have the permissions to change the label of this issue nor the issue title.

and what would be a correct title and label?

@joshsedl
Copy link

label: bug
title: Setting data attribute "data-control" won't render arrow controls (cloudimage-360-left, cloudimage-360-right, etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants