Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting data attribute "data-hide-360-logo" not only hides the logo, but also the arrow controls (cloudimage-360-left, cloudimage-360-right, etc.) #166

Open
joshsedl opened this issue Sep 19, 2024 · 2 comments

Comments

@joshsedl
Copy link

See https://codesandbox.io/p/sandbox/js-cloudimage-360-view-example-forked-l5czys?workspaceId=8f1a8c32-1ff9-48b7-95f5-36bf3e63b3e4.

Removing "data-hide-360-logo" will display the arrow controls once again.

@JPustkuchen
Copy link

Looks like this return statement causes this bug?

if (this.hide360Logo) return this.remove360ViewIcon();

To me it looks like the return should simply be removed?

@JPustkuchen
Copy link

Maintainers please check if that fix is correct. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants