Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazysizes lazyloading demo is missing the data-lazyload attribute, so the demo doesn't work #168

Open
thomasfrobieter opened this issue Sep 23, 2024 · 1 comment

Comments

@thomasfrobieter
Copy link

thomasfrobieter commented Sep 23, 2024

https://codesandbox.io/p/sandbox/js-cloudimage-360-view-examples-ux850x?file=%2Findex.html%3A41%2C34

data-lazyload="true"

EDIT:

Turns out, data-lazyload doesn't change anything, all images are still loaded without clicking the "360°"-button:

https://codesandbox.io/p/sandbox/js-cloudimage-360-view-examples-forked-kr9ctf

So I think 'data-lazyload-selector' is also required. Not sure how to use this..

@JPustkuchen
Copy link

I can confirm this, checking the network tab in the browser console. Images are not lazy loaded. They even load outside the viewport in the demo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants