Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time to tag v2.0.0? #12

Open
disq opened this issue Nov 3, 2023 · 5 comments
Open

Time to tag v2.0.0? #12

disq opened this issue Nov 3, 2023 · 5 comments

Comments

@disq
Copy link
Contributor

disq commented Nov 3, 2023

Do you think it's time to tag v2.0.0 with the new SDK? Just follow the steps in the readme and GoReleaser should take care of the rest for GitHub artifacts.

For the hub release you'll need to create a user in cloud.cloudquery.io and get added to the scaleway team (details in the PR description), but in a pinch I can do the release too.

@remyleone
Copy link
Member

Do you have anything to generate it automatically? Having to do a manual release each time the SDK will be updated will induce an ongoing run load on us that we do not guarantee at the moment. Having something automated on the cq-source-scaleway side seems to be the way to go.

@disq
Copy link
Contributor Author

disq commented Nov 8, 2023

@remyleone It can be a github action, but needs a GitHub secret setup.

Here's an example: https://github.com/cloudquery/cloudquery/blob/main/.github/workflows/publish_plugin_to_hub.yml

I can contribute something like this but it won't work without setting the token (CQ_CI_CLOUDQUERY_HUB_TOKEN in the link above) which is needed from your side. To do that you'll need to be included in the scaleway team in the hub but I still don't have your corp email for an invite, I can invite you with your gmail though, if that's preferred.

@remyleone
Copy link
Member

[email protected]

@disq
Copy link
Contributor Author

disq commented Nov 8, 2023

Opened #13 for the workflow. Also you should have an invitation in your email.

@disq
Copy link
Contributor Author

disq commented Nov 10, 2023

#14 fixes the workflow issues. You'll still need to accept the invite and set up the token as described in the README. (I've slightly changed the name of the secret name in #14 so it's different from before, please refer to that one)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants