ci: Run CI job on Ubuntu 22.04 #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andrea pointed out that we can and should be using Ubuntu 22.04. Unfortunately it still doesn't ship some of the deps we need like clang-17, but it does at least ship virtme-ng, so it's good for us to use this so that we can actually test running the schedulers in a virtme-ng VM when it supports being run in docker. Also, update the job to run on pushes, and not just when a PR is opened Suggested-by: Andrea Righi <[email protected]> Signed-off-by: David Vernet <[email protected]>
htejun
approved these changes
Dec 20, 2023
arighi
reviewed
Dec 20, 2023
There was a problem hiding this comment.
virtme-ng brings a lot of dependencies (all the kernel build dependencies basically). If this is slowing down the CI too much we may also consider to git clone https://github.com/arighi/virtme-ng.git and install only a subset of dependencies (that should be this: python3-pip qemu-system-x86 qemu-kvm libvirt-clients busybox-static kbd kmod file rsync zstd), like the bare minimum requirements to run vng and test a custom kernel.
But apart than that everything else looks good.
In the meantime I'll work on a fix for virtme-ng to properly support docker (see arighi/virtme-ng#51).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Andrea pointed out that we can and should be using Ubuntu 22.04. Unfortunately it still doesn't ship some of the deps we need like clang-17, but it does at least ship virtme-ng, so it's good for us to use this so that we can actually test running the schedulers in a virtme-ng VM when it supports being run in docker.
Also, update the job to run on pushes, and not just when a PR is opened
Suggested-by: Andrea Righi [email protected]