Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click on the "OK" notification and reveal the file in Finder? #10

Open
anthrotype opened this issue Nov 30, 2023 · 7 comments
Open

Click on the "OK" notification and reveal the file in Finder? #10

anthrotype opened this issue Nov 30, 2023 · 7 comments

Comments

@anthrotype
Copy link
Contributor

I have some code to reveal the font that the fontmake command just built in the Finder:

https://github.com/anthrotype/FontMakeExportPlugin/pull/1/files

@schriftgestalt Do you know if there is a way to trigger this only when the user actually clicks on the "OK" notification that you show when fontmake completed without errors?

I could not find a way to do that.

@anthrotype
Copy link
Contributor Author

anthrotype commented Nov 30, 2023

actually, it just occurred to me that, even if I manage to use pyobjc to customise the notification, since this is running from inside Python, the app would still continue to block waiting for the user to click on the notification that triggers the callback, am I right?
So that would not be acceptable.

@schriftgestalt
Copy link
Owner

What OK button do you mean?

Or do you mean you like to add that notification popup?

@anthrotype
Copy link
Contributor Author

This one that shows "OK" message when fontmake completes, you already added it (btw, I prefer "fontmake" all lowercase, not "fontMake" camelCase)

Screenshot 2023-11-30 at 15 45 39

I would like to be able to react on the user clicking this notification and reveal in the Finder the font file just built. Wouldn't it be nice?

@schriftgestalt
Copy link
Owner

For some reason I don’t get the notifications. I added some code inside the wrapper that should allow click to reveal the file. I can’t test this right now.

@anthrotype
Copy link
Contributor Author

For some reason I don’t get the notifications

strange. maybe that's controlled in the general macOS settings under Notification Center?

@florianpircher
Copy link

Notifications are often not delivered when in some focus mode (what used to be “do not disturb” mode).

@schriftgestalt
Copy link
Owner

Checked that. And check the notifications settings in System preferences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants