-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checkpoints #5
Comments
We need to decide the best way of implementing this when using the CS3APIs. On EOS, for example, the versions are created automatically. Currently, at CERN, we rely that a version was created during the save. So, in practice, the Jupyter endpoint to "create" a version only checks if a new version exists or not. The disadvantage is that we keep creating versions when the autosave kicks in, as opposed to only do that when the user clicks save. |
Now, I see three ways of implementation checkpoint in cs3api4lab:
|
Sorry for the late reply, I didn't see this ticket. But about your suggestions, I think the jupyterlab versioning should be exactly the same as any other application. If I create a version in Jupyter, then I want to see it from CERNBox/ownCloud and, maybe in the future, in the sync client. So I don't agree we save versions manually in different places, thus bypassing the normal logic. If this is not possible, I would implement the same behavior we currently have in SWAN: creating a version does not create a version. It assumes that the save already created one, so it just returns the latest. |
@mateusz-garlacz I've had a preliminary discussed with @labkode and it might be interesting to enable checkpoint functionality similar to what Jupyter does. But we still need to discuss it further (and eventually have it implemented). |
Still needs implementation: cs3org/cs3apis#97 |
Implement the checkpoints handlers for Jupyter. In Jupyter, these handler are independent of the save mechanism. Only if the user clicks in the save button (as opposed to automatic saves) - and the save is successful - the endpoint to create a version is called.
The text was updated successfully, but these errors were encountered: