Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce dependencies #71

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Reduce dependencies #71

wants to merge 1 commit into from

Conversation

stefanv
Copy link
Member

@stefanv stefanv commented Nov 19, 2024 •
edited
Loading

Closes #70

@stefanv
Reduce dependencies
5a3796c 
The publishing dependencies are much heavier than the query
dependencies, so make those optional.
bsipocz
bsipocz reviewed Nov 20, 2024
View reviewed changes
Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Submodule related failure is unrelated, however I think there is a typo left.

README.md
pip install devstats[publish]
```

(or, if you cloned the repository, `pip install -e[publish]`.)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this expected to work?

Suggested change
(or, if you cloned the repository, `pip install -e[publish]`.)
(or, if you cloned the repository, `pip install -e .[publish]`.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsipocz bsipocz bsipocz left review comments

Assignees
No one assigned
Labels
type: Maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider having different dependencies for query tool
2 participants
@stefanv @bsipocz