Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS pdf viewer #2

Open
eugenio-tesio opened this issue Jul 30, 2018 · 28 comments
Open

iOS pdf viewer #2

eugenio-tesio opened this issue Jul 30, 2018 · 28 comments

Comments

@eugenio-tesio
Copy link

Is there any intention to do the iOS pdf viewer?

@devxpy
Copy link
Member

devxpy commented Jul 30, 2018

If you can buy me a mac, sure!

Anyway, I believe @The-Redhat has solved it in his local testing but he doesn't have the time to integrate it into this plugin right now.

You can follow our discussion here

@eugenio-tesio
Copy link
Author

eugenio-tesio commented Jul 31, 2018 via email

@albo1337
Copy link

albo1337 commented Oct 2, 2018

Looking forward for iOS Support too. Is there anyone who can help us?

@devxpy devxpy mentioned this issue Oct 8, 2018
@devxpy
Copy link
Member

devxpy commented Oct 9, 2018

@albo1337 I'll try merging the IOS part on my freind's mac. Can you please check if there are night mode, password and horizontal scroll options available on the iOS side?

@albo1337
Copy link

@devxpy The problem is that I currently don't have my MacBook with me and I'm for 1 Month out of home... But as far as I know I did not implement the nightmode or the password functionality for iOS

@albo1337
Copy link

Just to let you know: I am using the standard webview in iOS to display pdf.

@eugenio-tesio
Copy link
Author

eugenio-tesio commented Oct 11, 2018 via email

@devxpy
Copy link
Member

devxpy commented Oct 11, 2018

@eugenio-tesio This plugin is for viewing pdf inside the flutter app itself, not for opening the file in a different app

@devxpy
Copy link
Member

devxpy commented Oct 11, 2018

@albo1337

standard webview

I don't feel like that's acceptable at all. We already have flutter_webview_plugin for doing webviews.

This plugin is intended to show PDFs inside of a native pdf viewer.

@albo1337
Copy link

Well iOS has the possibility to show pdf's in webview without external libraries. Why not showing it in a webview? Android can't so we had to implement a workaround for Android only.

@devxpy
Copy link
Member

devxpy commented Oct 11, 2018

Android also has the ability to show webviews without any external library.

(EDIT - you do need to load pdfjs inside the webview, but no, you don't need pdfium android)

My point was -- what's the use of this plugin if all it does is show stuff in a webview?

Webviews are a mediocre experience at best. Try loading very large PDFs and the webview will probably lag really bad.

You also, cannot load a webview from raw bytes without touching the filesystem, something which is important when dealing with sensitive documents. (Correct me if this doesn't apply to iOS)

@bjbelliveau
Copy link

Any update on this?

@devxpy
Copy link
Member

devxpy commented Oct 26, 2018

@albo1337 Are you aware of a solution on iOS that does not display in a web view?

Perhaps this?

@albo1337
Copy link

If I find some time I'm going to research how to implement this in our solution @devxpy . I keep you updated

@l-k22
Copy link

l-k22 commented Dec 3, 2018

If I find some time I'm going to research how to implement this in our solution @devxpy . I keep you updated

Hi @albo1337 , is there any update on this request? I recently came across this package which says it supports iOS, it also supports appbar. https://pub.dartlang.org/packages/flutter_full_pdf_viewer

@albo1337
Copy link

albo1337 commented Dec 4, 2018

If I find some time I'm going to research how to implement this in our solution @devxpy . I keep you updated

Hi @albo1337 , is there any update on this request? I recently came across this package which says it supports iOS, it also supports appbar. https://pub.dartlang.org/packages/flutter_full_pdf_viewer

This is actually my repository and it supports ios and android pdf viewer. The only part which I did not find time to implement is the iOS webview replacement with the pdf viewer.

@l-k22
Copy link

l-k22 commented Dec 4, 2018

If I find some time I'm going to research how to implement this in our solution @devxpy . I keep you updated

Hi @albo1337 , is there any update on this request? I recently came across this package which says it supports iOS, it also supports appbar. https://pub.dartlang.org/packages/flutter_full_pdf_viewer

This is actually my repository and it supports ios and android pdf viewer. The only part which I did not find time to implement is the iOS webview replacement with the pdf viewer.

Opps, I should have tagged @devxpy not you. Great package, it's what I'm using now just wish it could do horizontal scrolling 👍

@devxpy
Copy link
Member

devxpy commented Dec 4, 2018

@l-k22 And I wish apple stopped their monopoly of compilers and just let us do our work 😕

@l-k22
Copy link

l-k22 commented Dec 5, 2018

@devxpy , that would be nice.
@albo1337 and devxpy, sorry to go off topic but would either of you know how to implement a search feature? The pdfs within the app are scientific books so the user will want to search for specific keywords.

@devxpy
Copy link
Member

devxpy commented Dec 6, 2018

@l-k22 It's impossible for me, because the native PDF viewer lib I used doesn't support it.

@albo1337 Would probably be able to integrate such a feature, because he's using a webview IIRC. Given that apple would allow trivial access to text rendered on webview :)

@l-k22
Copy link

l-k22 commented Jan 15, 2019

Hello, I wondered if you have had any luck progressing with this issue, albo1337 seems to have gone dark. Thanks

@devxpy
Copy link
Member

devxpy commented Jan 15, 2019

@I-k22, please make a new issue regarding the text selection feature. Text selection requires a pdf parsing library that has open access to the content being displayed from within dart.

I haven't had any luck finding such a library yet.

devxpy pushed a commit that referenced this issue Jan 26, 2019
constraintlayout and test.runner to androidx
@MTschannett
Copy link

@devxpy I'd like to help with the IOs part. If you could help me getting started with which libraries to use or and which features are important.

I have access to a Mac and I'd like to use this library in one of my projects. If there is anything I could do, I'd be glad to help.

@devxpy
Copy link
Member

devxpy commented Mar 19, 2019

I forgot to update you guys here, but I'm soon getting a Mac myself, courtesy of Jaaga Labs.

We actually just launched a production app that uses this plugin - Meghshla online

You may expect a proof of concept, and even stable ios compat sometime around last week of next month.

@MTschannett
Copy link

@devxpy that's some good news ^^. Hope you have fun with your Mac ^^

@MaskyS
Copy link

MaskyS commented Apr 23, 2019

@devxpy How's it going :D

@devxpy
Copy link
Member

devxpy commented Apr 23, 2019

@MaskyS Kinda stuffed with work with the sponsor. The ios pdf is definitely on our roadmap, please give me some time.

@ammaratef45
Copy link

@devxpy I have a mac and I can help if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants