Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort out metadata fields #822

Closed
18 of 29 tasks
ShanaLMoore opened this issue Sep 20, 2024 · 4 comments
Closed
18 of 29 tasks

Sort out metadata fields #822

ShanaLMoore opened this issue Sep 20, 2024 · 4 comments
Assignees
@laritakr
Labels
M1 Milestone 1 needs rework issue needs additional work Valkyrie

Comments

@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Sep 20, 2024 •
edited by laritakr
Loading

Summary

related:

ref:

We have changed metadata from multiple to singular values. Will this cause a problem when converting prod data into valkyrie resources? Will we lose data?

For example, what if prod has multiple values but when we reindex, it should only have one?

This task is to look at each work type in prod and compare it to our metadata yaml definitions to make sure we match as much as possible.

Acceptance Criteria

  • This ticket can be closed after the following metadata yaml files have been verified/completed:
    • adl_metadata.yaml
    • collection_resource.yaml
    • conference_item_resource.yaml
    • dataset_resource.yaml
    • exam_paper_resource.yaml
    • generic_work_resource.yaml
    • image_resource.yaml
    • journal_article_resource.yaml
    • published_work_resource.yaml
    • thesis_resource.yaml

Testing Instructions

NOTE: This is an internal ticket that shouldn't require a review from the client

CREATE

Fill out all the metadata fields

create each work type and verify that you can successfully save

  • collection_resource
  • conference_item_resource
  • dataset_resource
  • exam_paper_resource
  • generic_work_resource
  • image_resource
  • journal_article_resource
  • published_work_resource
  • thesis_resource

EDIT

edit each work type and verify that you can successfully save

  • collection_resource
  • conference_item_resource
  • dataset_resource
  • exam_paper_resource
  • generic_work_resource
  • image_resource
  • journal_article_resource
  • published_work_resource
  • thesis_resource
@ShanaLMoore ShanaLMoore added Valkyrie M1 Milestone 1 labels Sep 20, 2024
@ShanaLMoore ShanaLMoore mentioned this issue Sep 20, 2024
Merged
kirkkwang added a commit that referenced this issue Sep 23, 2024
@kirkkwang
🐛 Fix metadata multiple or single
8c55d5e 
This commit will check Adventist production's metadata for it's multiple
and single values and compare it to Valkyrie's.  We spotted many
differences and this commit aims to resolve them.

Ref:
- #822
@kirkkwang kirkkwang mentioned this issue Sep 23, 2024
Merged
kirkkwang added a commit that referenced this issue Sep 23, 2024
@kirkkwang
🐛 Fix metadata multiple or single (#824)
46a3b8d 
This commit will check Adventist production's metadata for it's multiple
and single values and compare it to Valkyrie's. We spotted many
differences and this commit aims to resolve them.

Ref:
- #822
@ShanaLMoore
Copy link
Contributor Author

Audit completed by Sarah and Kirk. They've confirmed that they're still able to edit and save each work type after making these changes.

Image

@ShanaLMoore ShanaLMoore mentioned this issue Sep 25, 2024
Open
10 tasks
@ShanaLMoore ShanaLMoore reopened this Sep 25, 2024
@ShanaLMoore
Copy link
Contributor Author

ShanaLMoore commented Sep 25, 2024 •
edited by laritakr
Loading

TODO:

CREATE

Fill out all the metadata fields

create each work type and verify that you can successfully save

  • collection_resource
  • conference_item_resource
  • dataset_resource
  • exam_paper_resource
  • generic_work_resource
  • image_resource
  • journal_article_resource
  • published_work_resource
  • thesis_resource

EDIT

edit each work type and verify that you can successfully save

  • collection_resource
  • conference_item_resource
  • dataset_resource
  • exam_paper_resource
  • generic_work_resource
  • image_resource
  • journal_article_resource
  • published_work_resource
  • thesis_resource

@ShanaLMoore ShanaLMoore added the needs rework issue needs additional work label Sep 26, 2024
@ShanaLMoore
Copy link
Contributor Author

Katharine reported an inability to edit a Collection here.

The error says:

2024-09-25T22:39:58.658842776Z Error: ERROR: [doc=851b4393-f9d1-4fa1-b1d9-31bf589c8fff] Error adding field 'issue_number_isim'='Issue' msg=For input string: "Issue"

which was changed in the PR of this work.

@laritakr laritakr mentioned this issue Sep 26, 2024
Merged
kirkkwang added a commit that referenced this issue Sep 26, 2024
@kirkkwang
🐛 Change indexing for issue_number (#828)
5b79bcd 
Originally changed because it matches Adventist prior to Valkyrie, but
it seems to be causing issues so I'm changing it to _tesim.

Ref #822
@laritakr laritakr assigned laritakr and unassigned kirkkwang and sjproctor Sep 26, 2024
@laritakr laritakr mentioned this issue Sep 30, 2024
Merged
@laritakr
Copy link
Contributor

Closing... QA will be handled via #777 (see comment)

laritakr added a commit that referenced this issue Sep 30, 2024
@laritakr
Clean up metadata issues (#834)
655254f 
# Story

Metadata yaml files were audited and edited to:
- Change dates to be single rather than multiple
- Add multiple: false on form when term is not multiple... form defaults
to multiple and term defaults to singular.
- Remove unnecessary state & arkivo_checksum
- remove dc_access_rights, which shares the same predicate in fedora
with access_rights. (the shared predicate means they do the same thing,
and the term is not accessed except in indexing.)

Refs

- #777
- #822

# Expected Behavior Before Changes

Many works types could be created but not edited.
Metadata single or multiple on form did not match production.

# Expected Behavior After Changes

- All work types and collection can be created.
- All work types and collection can be edited.
- All fields [with the exception of based_near location
dropdown](#212)
can be used.

# Screenshots / Video

<details>
<summary></summary>

**All work types and collection were tested, and can be both created and
edited.**

![Screenshot 2024-09-30 at 4 09
38 PM](https://github.com/user-attachments/assets/69cd75bc-7323-48e6-9a16-a17b6f6eab56)

</details>

# Notes

OER and ETD do not currently work. These come in via Hyku and are not
used in Adventist, so they have not been adequately set up. At this
point, they should be deactivated in all tenants to avoid any potential
issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laritakr laritakr

Labels
M1 Milestone 1 needs rework issue needs additional work Valkyrie
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ShanaLMoore @laritakr @kirkkwang @sjproctor