Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metadata fields for V6 & Valkyrie #852

Open
18 of 20 tasks
KatharineV opened this issue Oct 10, 2024 · 3 comments
Open
18 of 20 tasks

Metadata fields for V6 & Valkyrie #852

KatharineV opened this issue Oct 10, 2024 · 3 comments
Assignees
@laritakr
Labels
M1 Milestone 1 Valkyrie

Comments

@KatharineV
Copy link
Collaborator

KatharineV commented Oct 10, 2024 •
edited by laritakr
Loading

Thank you for the spreadsheet of Complete Adventist Form Metadata. Going from that sheet, here are the fields to mask across our application and/or in certain work types.

Mask in all work types:

  • * altlabel
  • * label
  • * language code
  • * managing organisation
  • * on behalf
  • * owner
  • * preflabel
  • * rdfs_label

Mask in Collections

  • * date accepted
  • * date available
  • * date submitted
  • * depositor (proxy_depositor)
  • * funder
  • * issue (issue_number)
  • * orcid
  • * output of project (output_of)
  • * pages

Mask in Journal Article

  • * date (a date for the work)

Testing Instructions

  • Verify that the above terms are not on the works and collection forms as specified.
  • Verify that works and collections can still be created and edited
@KatharineV
Copy link
Collaborator Author

@laritakr this is the ticket I made after reviewing the metadata spreadsheet you gave. Thanks!

@laritakr laritakr added the M1 Milestone 1 label Oct 10, 2024
@laritakr laritakr self-assigned this Oct 14, 2024
laritakr added a commit that referenced this issue Oct 14, 2024
@laritakr
Hide metadata from forms
c131a3c 
Based on #852
@laritakr laritakr mentioned this issue Oct 14, 2024
Merged
laritakr added a commit that referenced this issue Oct 15, 2024
@laritakr
Hide metadata from forms (#854)
d9683f4 
# Story

Refs #852

# Expected Behavior Before Changes

Specified metadata appeared on UI forms

# Expected Behavior After Changes

Forms no longer contain specified metadata

# Screenshots / Video

<details>
<summary></summary>

</details>

# Notes
@kirkkwang
Copy link
Contributor

kirkkwang commented Oct 18, 2024 •
edited
Loading

✅ QA PASSES

Searched for all the fields and did not find any of the masked terms.

@KatharineV
Copy link
Collaborator Author

I created a new collection, a generic work, and a journal article on https://testing.s2.adventistdigitallibrary.org/?locale=en, and I did not see any of the masked fields in the UI. The masking worked as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laritakr laritakr

Labels
M1 Milestone 1 Valkyrie
Projects
Adventist Knapsack
Status: Deploy to Production
Milestone
No milestone
Development

No branches or pull requests
3 participants
@laritakr @kirkkwang @KatharineV