Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update banner image #657

Open
12 tasks
Tracked by #660
jillpe opened this issue Jul 22, 2024 · 4 comments
Open
12 tasks
Tracked by #660

Update banner image #657

jillpe opened this issue Jul 22, 2024 · 4 comments
Assignees
@kirkkwang
Labels
good first issue Good for newcomers Pre-Launch

Comments

@jillpe
Copy link

jillpe commented Jul 22, 2024 •
edited by kirkkwang
Loading

Summary

reference: https://docs.google.com/spreadsheets/d/1xRLL5b7Gs8ZrhH2K2QTP7oKBpKJjPTlcoh16tb1uj8Q/edit?gid=0#gid=0

Image cycles through a curated list.

Acceptance

  • Admin users have the ability to upload more than one banner image
  • The banner image displayed on the home page is randomly picked from the list of images.

Testing instructions

  • Go to the admin dashboard
  • Choose Settings -> Appearance -> Banner Image
  • Click Choose Files and upload a few banner images and click Save changes
  • Go to the homepage and observe that the banner images show
  • Refresh the page to get a random banner image
  • Waiting about 7 secs and watch the banner images cycle
  • Go back to the admin dashboard Settings -> Appearance -> Banner Image
  • Click Remove all banner images
  • Go back to the homepage
  • Observe that the default banner image now shows
@jillpe jillpe mentioned this issue Jul 22, 2024
Open
15 tasks
@orangewolf orangewolf added the good first issue Good for newcomers label Jul 23, 2024
@kirkkwang
Copy link
Contributor

Possible implementation

  • have the admin upload a zip of images, the images will then replace all previous images

kirkkwang added a commit that referenced this issue Aug 3, 2024
@kirkkwang
🎁 Allow admins to upload multiple banners
5178c1c 
This commit allows the admin to upload multiple banners to the homepage
through the dashboard.  The homepage will randomly select a banner and
then cycle through the uploaded banners.

Ref:
  - #657
kirkkwang added a commit that referenced this issue Aug 3, 2024
@kirkkwang
🎁 Allow admins to upload multiple banners
4abc4dd 
This commit allows the admin to upload multiple banners to the homepage
through the dashboard.  The homepage will randomly select a banner and
then cycle through the uploaded banners.

Ref:
  - #657
@kirkkwang kirkkwang self-assigned this Aug 4, 2024
kirkkwang added a commit that referenced this issue Aug 4, 2024
@kirkkwang
🎁 Allow admins to upload multiple banners
5bf1e5f 
This commit allows the admin to upload multiple banners to the homepage
through the dashboard.  The homepage will randomly select a banner and
then cycle through the uploaded banners.

Ref:
  - #657
kirkkwang added a commit that referenced this issue Aug 4, 2024
@kirkkwang
🎁 Allow admins to upload multiple banners
b07928d 
This commit allows the admin to upload multiple banners to the homepage
through the dashboard.  The homepage will randomly select a banner and
then cycle through the uploaded banners.  We introduce a new uploader,
`Hyku::UploadedFileUploader`, to handle the multiple file uploads and
change the concept of banner_image to banner_images.

Ref:
  - #657
kirkkwang added a commit that referenced this issue Aug 4, 2024
@kirkkwang
🎁 Allow admins to upload multiple banners
a5753e6 
This commit allows the admin to upload multiple banners to the homepage
through the dashboard.  The homepage will randomly select a banner and
then cycle through the uploaded banners.  We introduce a new uploader,
`Hyku::UploadedFileUploader`, to handle the multiple file uploads and
change the concept of banner_image to banner_images.

Ref:
  - #657
@kirkkwang kirkkwang mentioned this issue Aug 5, 2024
Merged
kirkkwang added a commit that referenced this issue Aug 5, 2024
@kirkkwang
🎁 Allow admins to upload multiple banners
753da3b 
This commit allows the admin to upload multiple banners to the homepage
through the dashboard.  The homepage will randomly select a banner and
then cycle through the uploaded banners.  We introduce a new uploader,
`Hyku::UploadedFileUploader`, to handle the multiple file uploads and
change the concept of banner_image to banner_images.

Ref:
  - #657
kirkkwang added a commit that referenced this issue Aug 5, 2024
@kirkkwang
🎁 Allow admins to upload multiple banners
7624705 
This commit allows the admin to upload multiple banners to the homepage
through the dashboard.  The homepage will randomly select a banner and
then cycle through the uploaded banners.  We introduce a new uploader,
`Hyku::UploadedFileUploader`, to handle the multiple file uploads and
change the concept of banner_image to banner_images.

Ref:
  - #657
@josh-morgan117
Copy link
Collaborator

@kirkkwang How would the alt text work for these?

@kirkkwang
Copy link
Contributor

@josh-morgan117 So the form field on the banner is a bit of a misnomer I feel. It actually doesn't add an alt-text attribute to the img tag because technically this is a background image of a div tag so there isn't an alt-text. What the field fills out is the title attribute which appears when you hover over the text. The way this is implemented is that all the images have the same title attribute.

@jillpe
Copy link
Author

jillpe commented Aug 12, 2024 •
edited
Loading

SoftServ QA: Pass ✅

  • Go to the admin dashboard
  • Choose Settings -> Appearance -> Banner Image
  • Click Choose Files and upload a few banner images and click Save changes
  • Go to the homepage and observe that the banner images show
  • Refresh the page to get a random banner image
  • Waiting about 7 secs and watch the banner images cycle
  • Go back to the admin dashboard Settings -> Appearance -> Banner Image
  • Click Remove all banner images
  • Go back to the homepage
  • Observe that the default banner image now shows
Screenshots/Videos

Image

Screen.Recording.2024-08-12.at.8.06.22.AM.mov

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kirkkwang kirkkwang

Labels
good first issue Good for newcomers Pre-Launch
Projects
utk-hyku
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@orangewolf @josh-morgan117 @kirkkwang @jillpe