Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it work with 'array' dtype #1

Closed
rreusser opened this issue Jan 3, 2016 · 2 comments
Closed

Make it work with 'array' dtype #1

rreusser opened this issue Jan 3, 2016 · 2 comments

Comments

@rreusser
Copy link
Member

rreusser commented Jan 3, 2016

See: scijs/ndarray-scratch#5. If that's merged, then this works automatically.

@rreusser
Copy link
Member Author

Upon reflections, these functions should not be doing their own internal allocation. That's a great way to leak memory all over the place. I've replaced this to only work on existing ndarrays.

@rreusser
Copy link
Member Author

rreusser commented Nov 27, 2016

Additionally since the only use-case of providing a size is shorthand for not specifying an input. Which makes inconsistencies possible and only saves like 5-10 characters. Seems more worthwhile to simplify the API. Bottom line: leaving allocation to the user so that this won't leak memory by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant