Skip to content
This repository has been archived by the owner on May 21, 2024. It is now read-only.

Binned chi2 zero bins #60

Open
WMGoBuffs opened this issue Jun 3, 2015 · 1 comment
Open

Binned chi2 zero bins #60

WMGoBuffs opened this issue Jun 3, 2015 · 1 comment
Milestone

Comments

@WMGoBuffs
Copy link

If I am fitting a Gaussian distributed variable with BinnedChi2, I am seeing a ValueError if one of the bins in the tails happens to be zero. The method throws this ValueError when the bin error is less than a small threshold value, but does not check to see if the bin weight is also zero. Can this case be checked before bringing the whole thing crashing down?

@cdeil
Copy link
Contributor

cdeil commented Oct 21, 2016

@WMGoBuffs - Thanks for filing the issue.

probfit hasn't been very active, so don't expect someone to pick up the suggestion and implement the change, you'll probably have to do it yourself.

The first step would be to post a minimal example (ideally just a few bins) showing:

  • the ValueError you get now.
  • mentioning the result you'd like to obtain for that case.

Once it's clear what exactly should happen, we can discuss if it's sensible, and then probably implementing it isn't very hard.

@cdeil cdeil added this to the wishlist milestone Oct 21, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants