-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Construction of qmutilde for muhat < 0 #2352
Comments
So following up on some discussion points raised by @cranmer from our NYU/UW-Madison group meeting discussion:
A question that I have is if you believe that you would be in a situation where (edit) |
I agree that "incorrect" is not a good description, maybe "inconsistent with the definition" is better. The question about the usefulness of that approach in such a scenario stands of course. Regarding your question: |
Quick comment, the situation |
Sorry, you're both obviously correct, but I was typing #2352 (comment) while trying to listen to another meeting and I typoed. I meant to write
(so not but if I had read better I would have seen that @alexander-held addressed this in the first sentence:
so we're already starting there with the answer to my question. |
@alexander-held For reference, as you mention in your 2023-10-16 ATLAS Statistics Committee Meeting slides this was addressed in
I'm assuming this is https://gitlab.cern.ch/will/xroofit/-/commit/ebf6a49194c3c08dd2e12d8933fe16067b6243e8 ( |
I believe so, @will-cern can presumably confirm. |
For models with some physically motivated bounds (like$\mu\geq0$ ) the $\tilde{q}_\mu$ test statistic is defined in https://arxiv.org/abs/1007.1727 at equation 16. The use of this test statistics in $\mu\geq0$ parameter bound: see code.
pyhf
seems to rely on setting aThis is generally going to give a result consistent with the prescription given in the formula, as for any (at least approximately) parabolic likelihoods where$\hat{\mu} < 0$ , the result when constraining $\mu\geq0$ is going to be $\hat{\mu} = 0$ .
There is a notable exception that arises for quadratic POI dependence, where a second local minimum can appear (e.g. common for EFT measurements). For$\hat{\mu} < 0$ and a second local minimum at $\mu>0$ , the $\tilde{q}_\mu$ prescription would require performing an additional fit with $\mu=0$ to evaluate the correct denominator. See the following figure for such an example:
As far as I am aware, the current
pyhf
implementation would incorrectly evaluate the test statistic by using the local minimum in the denominator.The text was updated successfully, but these errors were encountered: