-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: miscellaneous RNTuple improvements #1250
Conversation
@jpivarski this PR is ready for review now. Here are some highlights/comments:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice—I like the grouped enums! As far as I can see, these are maintainability updates, not changes in how the code functions. (Okay, I see that the PR title contains "chore:" rather than "feat:" or "fix:".)
Again, I'm forwarding you (email) the information about the RC3 format change, which is likely to be the last one ever.
Feel free to merge this PR!
This PR addresses the issues in #1220. I fixed the
__len__
method so that it returns the number of top-level columns instead of the number of entries, which is now thenum_entries
property.I'll work on implementing an
iterate
method and update this description when it's ready.