Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: miscellaneous RNTuple improvements #1250

Merged
merged 29 commits into from
Nov 5, 2024

Conversation

ariostas
Copy link
Collaborator

This PR addresses the issues in #1220. I fixed the __len__ method so that it returns the number of top-level columns instead of the number of entries, which is now the num_entries property.

I'll work on implementing an iterate method and update this description when it's ready.

src/uproot/const.py Outdated Show resolved Hide resolved
@ariostas
Copy link
Collaborator Author

ariostas commented Oct 4, 2024

I made some more updates to keep up to date with the spec. I'll wrap up this PR next week and possibly just postpone the implementation of iterate to another PR.

Closes #1288, closes #1302, closes #1303

@ariostas ariostas marked this pull request as ready for review November 5, 2024 14:33
@ariostas
Copy link
Collaborator Author

ariostas commented Nov 5, 2024

@jpivarski this PR is ready for review now. Here are some highlights/comments:

Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice—I like the grouped enums! As far as I can see, these are maintainability updates, not changes in how the code functions. (Okay, I see that the PR title contains "chore:" rather than "feat:" or "fix:".)

Again, I'm forwarding you (email) the information about the RC3 format change, which is likely to be the last one ever.

Feel free to merge this PR!

@ariostas ariostas merged commit 94d9684 into main Nov 5, 2024
26 checks passed
@ariostas ariostas deleted the ariostas/misc_rntuple_improvements branch November 5, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants