Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

several tests failing against local build of master branch #836

Closed
ctdunc opened this issue Apr 3, 2024 · 4 comments
Closed

several tests failing against local build of master branch #836

ctdunc opened this issue Apr 3, 2024 · 4 comments

Comments

@ctdunc
Copy link
Contributor

ctdunc commented Apr 3, 2024

Describe the bug
A few of the tests are failing against a local build of master. I am running the latest stable Debian in WSL.

  • test_model > test_solve_concurrent segfaults when built against scip compiled with -DAUTOBUILD=on -DTPI=any with soplex. This does not occur on the PyPI version as it is not built with TPI enabled.
  • test_model > test_locale fails as pt_PT is an invalid locale.
  • test_nonlinear > test_addExprNonLinear fails as y=2.0000163858811364 instead of 2. It may not be respecting the new epsilon?

To Reproduce
pip install .;pytest.
Expected behavior
Tests should pass.

System

  • OS: Debian GNU/Linux 12 (bookworm)
  • SCIP version: 9
  • How did you install pyscipopt? Locally
@Joao-Dionisio
Copy link
Collaborator

Hello, @ctdunc, thank you for the issue! Also, thank you for your other awesome issue, sorry for not saying anything. These are just general comments and don't really fix the issues.

  • I'm not sure whether I've ever run the parallelism tests since I usually compile SCIP without TPI, but it seems to be causing a bunch of issues (Problems in using concurrent solver, both tny and omp not works #780, among others)
  • pt_PT is a valid locale (it's the one I have :) ), but it's not a standard one, I think you need to maybe install it somehow? This may work: sudo apt-get install tzdata locales -y && sudo locale-gen pt_PT && sudo update-locale
  • I had already noticed the test_addExprNonLinear one, but I assumed it was a problem with my machine, as it is passing on the pipelines. I have to look into it.

@ctdunc
Copy link
Contributor Author

ctdunc commented Apr 3, 2024

Thank you for clarifying. Mostly wanted to confirm that I was not creating these issues somehow with my local build or missing others in my PR on the other issue

@ctdunc ctdunc closed this as completed Apr 3, 2024
@Joao-Dionisio
Copy link
Collaborator

Joao-Dionisio commented Apr 3, 2024

No problem, @ctdunc! But I'll reopen the issue, since this is still something we need to look at :)

EDIT: I hypothesize that the nonlinear test is failing because neither of us has IPOPT. I'll have to test this at some point.

@Joao-Dionisio Joao-Dionisio reopened this Apr 3, 2024
@Joao-Dionisio
Copy link
Collaborator

I concluded that the nonlinear test is not problematic. Since the PT test is fixed and the concurrent test is more related to the other open issues, I'm going to close this one.

It also marks the 500th closed issue 🎆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants