Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for event handlers #898

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Add documentation for event handlers #898

merged 3 commits into from
Sep 12, 2024

Conversation

mmghannam
Copy link
Member

No description provided.

Copy link
Collaborator

@Opt-Mucca Opt-Mucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only change I'd suggest is splitting the second subsection into multiple subsections. Something like:
"What is an event handler?"
"Adding Event Handlers with Callbacks"
"Add Event Handler Classes"

docs/tutorials/eventhandler.rst Outdated Show resolved Hide resolved
docs/tutorials/eventhandler.rst Show resolved Hide resolved
@Opt-Mucca
Copy link
Collaborator

I am super happy to see you already building on the documentation!
I'm a bit picky on this one because I don't see us changing stuff regularly here once it's added here.

@mmghannam
Copy link
Member Author

I am super happy to see you already building on the documentation!

You've made it quite smooth to add on the structure you've built so thank you!

I'm a bit picky on this one because I don't see us changing stuff regularly here once it's added here.

No worries, pick all you want 😄 anything that's going to make it a better experience for users I'm all for, and thanks for the quick review!

@Opt-Mucca
Copy link
Collaborator

We have liftoff!

@Opt-Mucca Opt-Mucca merged commit d5d53bd into master Sep 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants