Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing function for testing langchainjs #466

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

phracek
Copy link
Member

@phracek phracek commented Dec 11, 2024

Add missing function for testing langchainjs

The revision was added with 'v' prefix, but upstream
repository do not use it.

This pull request fixes bug introduced by #462

@phracek
Copy link
Member Author

phracek commented Dec 11, 2024

[test-upstream]

Copy link

github-actions bot commented Dec 11, 2024

Pull Request validation

Failed

🔴 Review - Missing review from a member (2 required)

Success

🟢 CI - All checks have passed

@phracek

This comment was marked as outdated.

Copy link

github-actions bot commented Dec 11, 2024

Testing Farm results

namecomposearchstatusstarted (UTC)timelogs
CentOS Stream 10 - 22-minimalCentOS-Stream-10x86_64✅ passed11.12.2024 11:36:539min 52stest pipeline
Fedora - 22-minimalFedora-latestx86_64✅ passed11.12.2024 11:37:529min 41stest pipeline
Fedora - 18-minimalFedora-latestx86_64✅ passed11.12.2024 11:36:4310min 55stest pipeline
CentOS Stream 10 - 22CentOS-Stream-10x86_64✅ passed11.12.2024 11:36:5110min 15stest pipeline
Fedora - 18Fedora-latestx86_64✅ passed11.12.2024 11:36:4513min 37stest pipeline
Fedora - 22Fedora-latestx86_64✅ passed11.12.2024 11:36:5215min 27stest pipeline
Fedora - 20Fedora-latestx86_64✅ passed11.12.2024 11:36:4317min 22stest pipeline
CentOS Stream 9 - 20CentOS-Stream-9x86_64✅ passed11.12.2024 11:36:4315min 14stest pipeline
RHEL9 - 18-minimalRHEL-9.4.0-Nightlyx86_64✅ passed11.12.2024 11:36:4616min 11stest pipeline
RHEL9 - 18RHEL-9.4.0-Nightlyx86_64✅ passed11.12.2024 11:36:4220min 5stest pipeline
RHEL8 - 18-minimalRHEL-8.10.0-Nightlyx86_64✅ passed11.12.2024 10:52:4518min 3stest pipeline
RHEL8 - 18RHEL-8.10.0-Nightlyx86_64✅ passed11.12.2024 11:36:4319min 37stest pipeline
Fedora - 20-minimalFedora-latestx86_64✅ passed11.12.2024 11:36:4419min 24stest pipeline
RHEL9 - 20RHEL-9.4.0-Nightlyx86_64✅ passed11.12.2024 11:36:4320min 21stest pipeline
RHEL9 - 22RHEL-9.4.0-Nightlyx86_64✅ passed11.12.2024 11:36:5120min 44stest pipeline
CentOS Stream 9 - 20-minimalCentOS-Stream-9x86_64✅ passed11.12.2024 11:36:5419min 42stest pipeline
RHEL8 - 20RHEL-8.10.0-Nightlyx86_64✅ passed11.12.2024 11:36:4522min 35stest pipeline
RHEL9 - 20-minimalRHEL-9.4.0-Nightlyx86_64✅ passed11.12.2024 11:36:4425min 20stest pipeline
RHEL8 - 20-minimalRHEL-8.10.0-Nightlyx86_64✅ passed11.12.2024 11:36:4328min 11stest pipeline
RHEL9 - 22-minimalRHEL-9.4.0-Nightlyx86_64✅ passed11.12.2024 11:46:0115min 46stest pipeline

Revision was added with 'v' prefix, but upstream
repository do not use it.

Signed-off-by: Petr "Stone" Hracek <[email protected]>
@phracek
Copy link
Member Author

phracek commented Dec 11, 2024

[test]

@phracek
Copy link
Member Author

phracek commented Dec 11, 2024

@lholmquist @pacostas Please review it.

Copy link
Contributor

@pacostas pacostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pacostas
Copy link
Contributor

pacostas commented Dec 12, 2024

Thank you for the fix. Luke is on PTO, so I dont think he will be able to approve it soon.
I approved it but I'm not a reviewer, so practically wont count on this PR the review. Feel free to merge if that is possible.

@phracek phracek merged commit 499db72 into master Dec 12, 2024
21 checks passed
@phracek phracek deleted the fix_langchain branch December 12, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants