Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable GitHub API request throttling to avoid hitting API rate limit #103

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Conversation

jamacku
Copy link
Member

@jamacku jamacku commented Jan 18, 2024

It implements best practices for using the GitHub API as described in docs.

When the primary rate limit is hit, it will log a warning and wait before trying the API endpoint again before failing.

Replaces: #95

@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c9dff33) 99.37% compared to head (8431354) 99.37%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #103   +/-   ##
=======================================
  Coverage   99.37%   99.37%           
=======================================
  Files           6        6           
  Lines         482      483    +1     
  Branches       50       50           
=======================================
+ Hits          479      480    +1     
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

It implements best practices for using the GitHub API as described in
https://developer.github.com/v3/guides/best-practices-for-integrators/#dealing-with-abuse-rate-limits

When the primary rate limit is hit, it will log a warning and wait before
trying the API endpoint one more time before failing.
@zmiklank zmiklank merged commit f2e7a2d into sclorg:main Jan 22, 2024
5 checks passed
@jamacku jamacku deleted the api branch January 22, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants