Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tmt_plan_filter is being ignored #230

Closed
WOnder93 opened this issue Sep 5, 2024 · 6 comments · Fixed by #231
Closed

tmt_plan_filter is being ignored #230

WOnder93 opened this issue Sep 5, 2024 · 6 comments · Fixed by #231
Assignees
Labels
type: bug Something isn't working

Comments

@WOnder93
Copy link

WOnder93 commented Sep 5, 2024

Type of issue

Bug Report

Description

Example: https://github.com/WOnder93/selinux-testsuite/actions/runs/10721083736/job/29728763570

I'm passing tmt_plan_filter: tag:ci, yet both plans are executed instead of only the matching one and in the pipeline logs there is only "plan_filter":null with no sign of the filter being passed to the actual TF request.

Reproducer

No response

@github-actions github-actions bot added the type: bug Something isn't working label Sep 5, 2024
@jamacku jamacku added not a bug and removed type: bug Something isn't working labels Sep 5, 2024
@jamacku
Copy link
Member

jamacku commented Sep 5, 2024

I'm pretty sure that you are missing ' in your workflow. Could you please try tmt_plan_filter: 'tag:ci'?

@WOnder93
Copy link
Author

WOnder93 commented Sep 5, 2024

@jamacku jamacku added type: bug Something isn't working and removed not a bug labels Sep 6, 2024
@jamacku
Copy link
Member

jamacku commented Sep 6, 2024

Thanks for trying. I'll have a look.

@jamacku jamacku self-assigned this Sep 6, 2024
@jamacku
Copy link
Member

jamacku commented Sep 6, 2024

@WOnder93 I have submitted PR with the fix. You can try it by using jamacku/testing-farm-as-github-action@filter instead of sclorg/[email protected].

@WOnder93
Copy link
Author

WOnder93 commented Sep 9, 2024

I tested with current sclorg/testing-farm-as-github-action@main, and it works, thanks!

@jamacku
Copy link
Member

jamacku commented Sep 9, 2024

@WOnder93 Thank you for testing 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
2 participants