-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing Farm as Git Hub Action - Typescript version 🚜 #84
Conversation
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
Action items for zmiklank - look at how |
This PR aims to reimplement the current Action in a language that will allow easier extendability and testability than the current composite yaml/python/bash implementation. This PR is keeping the current behavior/inputs/outputs except: - input debug - removed - we should use the native version of running Actions in debug mode - https://docs.github.com/en/actions/monitoring-and-troubleshooting-workflows/enabling-debug-logging
So it is used only when using this action to test a PR. Only used to obtain sha of the latest commit in PR. If this can be obtained in some more straightforward way then we do not need this. Also, if we want to remove this input, even though it seems like non-breaking change, I would consider to release it as tfaga v3. TODO for @zmiklank: to create needed changes in tfaga-wrapper as discussed in person. |
The 'typescript' branch in tfaga-wrapper was created. I also created draft PR for nginx that moves nginx testing to this typescript-written tfaga once this PR is merged to 'typescript' branch. |
@phracek, I have added a |
@jamacku I see there is checkbox called |
@phracek, It was just a note for me to try to test it "manually" using my fork of nginx-container, but I think the best would be to test it directly in nginx-container upstream. I did some basic tests and the basics work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to merge it to typescript branch and start with testing on real container. Let's fix problems in typescript branch in real life.
* Testing Farm as Git Hub Action - Typescript version This PR aims to reimplement the current Action in a language that will allow easier extendability and testability than the current composite yaml/python/bash implementation. This PR is keeping the current behavior/inputs/outputs except: - input debug - removed - we should use the native version of running Actions in debug mode - https://docs.github.com/en/actions/monitoring-and-troubleshooting-workflows/enabling-debug-logging * doc: update format of USAGE.md * Basic integration test * fix: apply the requested changes * remove makefile, no longer in use * doc: More documentation * doc: Add `DEVELOPMENT` document * ci: drop schedule for codeql analysis
This PR aims to reimplement the current Action in a language that will allow easier extendability and testability than the current composite yaml/python/bash implementation.
I chose TypeScript because it's the language Git Hub uses to write the official Actions. There are a lot of libraries that make writing GitHub Actions easier than in other languages.
This PR is keeping the current behavior/inputs/outputs except:
inputgit_url
- removed - this value can be gathered from the GitHub contextdebug
- removed - we should use the native version of running Actions in debug mode - https://docs.github.com/en/actions/monitoring-and-troubleshooting-workflows/enabling-debug-loggingNotes from going through the current implementation:
pr_head_sha
- is this useful/needed?outputs - are they used outside of the tfaga Action?TODO:
Manual testing of all potential scenarios/ configurationsSuggestions