Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update status description to show uncropped message and correctly display Details url when tests fail #88

Merged
merged 3 commits into from
Nov 28, 2023

Conversation

jamacku
Copy link
Member

@jamacku jamacku commented Nov 27, 2023

No description provided.

@jamacku jamacku changed the title fix: update status description to show uncropped message fix: update status description to show uncropped message and correctly display Details url when tests fail Nov 28, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (399d6d8) 93.24% compared to head (fc11540) 93.17%.

Files Patch % Lines
src/action.ts 16.66% 5 Missing ⚠️
src/error.ts 61.53% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff               @@
##           typescript      #88      +/-   ##
==============================================
- Coverage       93.24%   93.17%   -0.07%     
==============================================
  Files               4        5       +1     
  Lines             459      469      +10     
  Branches           36       36              
==============================================
+ Hits              428      437       +9     
- Misses             31       32       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. THanks for fix.

@phracek phracek merged commit a690f78 into sclorg:typescript Nov 28, 2023
5 checks passed
@jamacku jamacku deleted the fix-status branch November 28, 2023 08:50
zmiklank pushed a commit that referenced this pull request Jan 18, 2024
…y display Details url when tests fail (#88)

* fix: update status description to show uncropped message

* fix: missing url in status when tests fail

* test: update test for pull request comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants