Refactor of git status #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 5, 2018
|
I suggest you parse |
|
I agree with this. The main blocker I have here is that my ruby knowledge is pretty newbie and the syntax/concepts were tripping me up a lot just getting this into merge. I did revert this with #269 with the TODO being, learn enough ruby to parse |
|
I may be able to help with that; my Ruby chops are decent. I’ll try to find some time this week to check it out. |
|
That'd be awesome!_! You need any guidance at all about what we think needs
to get done to fit this sonny in, don't hesitate!
…On Mon, Sep 10, 2018 at 6:45 PM Jeff Byrnes ***@***.***> wrote:
I may be able to help with that; my Ruby chops are decent. I’ll try to
find some time this week to check it out.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#262 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJyKnDgWB_fZHg0V18po_7QnhEKiUBwks5uZtYkgaJpZM4WVyjR>
.
|
|
@jeffbyrnes Thanks for the offer! I'd be willing to review your code. |
|
Haven‘t yet had any bandwidth to tackle this, sorry! One day soon, I hope. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long time coming. Let's dogfood this for a bit, but I think it'll work well. I left the legacy version in the source code for now so it's a little bit easier to hack it back in if this break anything for anyone.