Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed completions for 'gl' and 'gla' aliases #319

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Fixed completions for 'gl' and 'gla' aliases #319

merged 2 commits into from
Feb 27, 2024

Conversation

telzhov
Copy link

@telzhov telzhov commented Nov 10, 2022 •
edited
Loading

Closes #320

@telzhov telzhov mentioned this pull request Nov 10, 2022
Closed
@ghthor
Copy link
Member

ghthor commented Nov 16, 2022

This changes the argument definition from a single string into an array of strings? That seems fine to me.

@telzhov
Copy link
Author

telzhov commented Nov 16, 2022

Right, because __git_alias function defined above in that file expects the argument list split into array:

__git_alias () {
    ...
    if [ $# -gt 2 ]; then
      shift 3 2>/dev/null
      cmd_args=("$@")
    fi

@telzhov
Copy link
Author

telzhov commented Jul 19, 2023

Hi,
I see that this PR hasn't been accepted so far. You don't find these changes really useful, don't you?..
Thanks!

@jeffbyrnes
Copy link
Contributor

Would sure be nice to have this merge in!

@ghthor
Copy link
Member

ghthor commented Feb 23, 2024

Hi, I see that this PR hasn't been accepted so far. You don't find these changes really useful, don't you?.. Thanks!

No, I've just been lazy

ghthor
ghthor approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@ghthor ghthor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how to make a test for this, but did test these changes locally

.scm_breeze/test (dac7e1e) [?] 
❯ source ~/.scm_breeze/scm_breeze.sh 

Tue Feb 27 06:11:40 2024 exit 0 🟢 took 29s
.scm_breeze/test (dac7e1e) [?] 
❯ type gl
gl is aliased to `git log --graph --pretty=format:'%Cred%h%Creset -%C(yellow)%d%Creset %s %Cgreen(%cr) %C(bold blue)<%an>%Creset' --abbrev-commit'

Tue Feb 27 06:11:44 2024 exit 0 🟢
.scm_breeze/test (dac7e1e) [?] 
❯ type gla
gla is aliased to `git log --graph --pretty=format:'%Cred%h%Creset -%C(yellow)%d%Creset %s %Cgreen(%cr) %C(bold blue)<%an>%Creset' --abbrev-commit --branches --remotes'

.scm_breeze/test (dac7e1e) [?] 
❯ gla -n2
*   dac7e1e - (HEAD, scm_breeze/pr/319) Merge branch 'master' into master (6 minutes ago) <Will Owens>
|\  
| *   b2b666b - (scm_breeze/master) Merge pull request #333 from ghthor/switch-to-github-actions (13 minutes ago) <Will Owens>
| |\  

.scm_breeze/test (dac7e1e) [?] 
❯ gl -10 HEAD^
* a430817 - Fixed completions for 'gl' and 'gla' aliases (1 year, 4 months ago) <telzhov>

@ghthor ghthor disabled auto-merge February 27, 2024 11:16
@ghthor ghthor disabled auto-merge February 27, 2024 11:19
@ghthor ghthor merged commit bb7fdaa into scmbreeze:master Feb 27, 2024
4 checks passed
@telzhov
Copy link
Author

telzhov commented Mar 13, 2024

Hi, I see that this PR hasn't been accepted so far. You don't find these changes really useful, don't you?.. Thanks!

No, I've just been lazy

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghthor ghthor ghthor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Completions for 'gl' and 'gla' aliases doesn't work
3 participants
@telzhov @ghthor @jeffbyrnes